Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens it usually means that the lldb Xcode project must be updated and it's too much to ask from all open source contributors to get access to a machine running Xcode to do this. Instead one of the Apple LLDB developers usually goes in and updates the Xcode project for them.
-- adrian > On May 18, 2018, at 9:04 AM, Amara Emerson via Phabricator > <revi...@reviews.llvm.org> wrote: > > aemerson reopened this revision. > aemerson added a comment. > This revision is now accepted and ready to land. > > Hi Pavel, > > I reverted this in r332730 due to the bot breaking. Please have a look and > commit again when ready. > > Thanks, > Amara > > > Repository: > rL LLVM > > https://reviews.llvm.org/D46889 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
