Can you help me understand why this dependency poses a problem? It's not clear to me how to resolve this otherwise. The point of the patch is to ask the clang driver for the clang module cache path. If the problem is that we otherwise don't use the driver and now pull it in, would moving the Clang API into a different clang library work? Which one?
-- adrian > On May 22, 2018, at 11:28 AM, Zachary Turner <ztur...@google.com> wrote: > > This change has introduced a dependency from Core -> clang Driver (due to > #include "clang/Driver/Driver.h" in ModuleList.cpp). Can you please try to > find a way to remove this dependency? > > On Fri, Mar 2, 2018 at 2:45 PM Phabricator via Phabricator via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: > This revision was not accepted when it landed; it landed in state "Needs > Review". > This revision was automatically updated to reflect the committed changes. > Closed by commit rL326628: Make the clang module cache setting available > without a target (authored by adrian, committed by ). > Herald added a subscriber: llvm-commits. > > Changed prior to commit: > https://reviews.llvm.org/D43984?vs=136803&id=136858#toc > <https://reviews.llvm.org/D43984?vs=136803&id=136858#toc> > > Repository: > rL LLVM > > https://reviews.llvm.org/D43984 <https://reviews.llvm.org/D43984> > > Files: > lldb/trunk/include/lldb/Core/ModuleList.h > lldb/trunk/include/lldb/Target/Target.h > lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/Makefile > > lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py > lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/f.h > lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/main.m > > lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/module.modulemap > lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py > lldb/trunk/source/Core/Debugger.cpp > lldb/trunk/source/Core/ModuleList.cpp > lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp > lldb/trunk/source/Target/Target.cpp > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits>
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
