clayborg added a comment.

I think we should expose the llvm::sys::RWMutex and lets clients like 
BuildAddressRangeTable and SymbolFileDWARF::Index use it and get rid of 
m_die_array_usecount all together.



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:181
+  // ExtractDIEsIfNeeded() will keep m_die_array populated forever.
+  uint32_t m_die_array_usecount = 0;
   // GetUnitDIEPtrOnly() needs to return pointer to the first DIE.
----------------
Why don't we expose the llvm::sys::RWMutex for BuildAddressRangeTable and 
SymbolFileDWARF::Index? Then they can just grab the read lock?


https://reviews.llvm.org/D40470



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to