Hui added inline comments.
================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:696
+ base_ast_type.GetOpaqueQualType(), access,
+ pdb_base_class->isVirtualBaseClass(), /*base_of_class*/ true);
+ base_classes.push_back(base_spec);
----------------
aleksandr.urakov wrote:
> Hui wrote:
> > aleksandr.urakov wrote:
> > > If I understand correctly, `base_of_class` must be `false` for structs.
> > > May be check the kind of `pdb_udt` here?
> > Struct/Union can't have base class. Only class udt is handled. I think it
> > is safe to set it ture.
> I think that it must be `false` for following code:
> ```
> class B {
> char _b;
> };
>
> struct S : B {
> int _s;
> };
> ```
Agree.
https://reviews.llvm.org/D49410
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
