xiaobai added a comment.
Looks good
================
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
----------------
keith wrote:
> xiaobai wrote:
> > This should not just depend on `framework_headers`, because those are in
> > the location `${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders`. You want to
> > run the script on `$<TARGET_FILE_DIR:liblldb>/Headers`, which is not
> > guaranteed to exist or have been populated with headers when this actually
> > gets run. See my comment above.
> Updated this by making it a POST_BUILD command instead
Can you combine this with the lldb-framework POST_BUILD above? After that this
should be good to go.
https://reviews.llvm.org/D49779
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
