labath added inline comments.
================
Comment at: unittests/Utility/StreamTest.cpp:38-41
+TEST_F(StreamTest, ChangingByteOrder) {
+ s.SetByteOrder(lldb::eByteOrderPDP);
+ EXPECT_EQ(lldb::eByteOrderPDP, s.GetByteOrder());
+}
----------------
probinson wrote:
> teemperor wrote:
> > labath wrote:
> > > <musing> I've been wondering for a while whether we shouldn't just remove
> > > PDP byte order support. Most of our code doesn't really support it, and
> > > neither does llvm's, so this is kind of a prerequisite for switching to
> > > llvm streams. </musing>
> > I support this notion. think most of LLDB's algorithms do not respect PDP
> > ordering.
> PDP ordering? As in, PDP-11? I could imagine GDB had to support it many
> long ages ago, but AFAIK no such machine has been produced this century.
This millenium, even. :P
Ok, I'll see if I can dismantle it.
Repository:
rL LLVM
https://reviews.llvm.org/D50027
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
