aprantl added inline comments.
================
Comment at: scripts/Python/python-typemaps.swig:89
+ PyErr_SetString(PyExc_ValueError, "Not a valid StateType value");
+ return nullptr ;
+ }
----------------
nice!
There's an extra space before the `;`
================
Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:779
switch (state) {
+ case kNumStateType:
case eStateConnected:
----------------
Shouldn't this value trigger an error of sorts in all of these switch
statements?
https://reviews.llvm.org/D51445
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
