I don’t think I’m really a good person to look at AST stuff. I can look for general style comments, obvious flaws, and test coverage. but you may be the best person regarding on the content of the patch. Does that sound ok? On Fri, Aug 31, 2018 at 7:20 AM Aleksandr Urakov via Phabricator < [email protected]> wrote:
> aleksandr.urakov updated this revision to Diff 163528. > aleksandr.urakov added a comment. > > Drop a scope part of a class member function name. > > > https://reviews.llvm.org/D51162 > > Files: > include/lldb/Symbol/ClangASTContext.h > lit/SymbolFile/PDB/class-layout.test > lit/SymbolFile/PDB/func-symbols.test > lit/SymbolFile/PDB/pointers.test > source/Plugins/SymbolFile/PDB/PDBASTParser.cpp > source/Plugins/SymbolFile/PDB/PDBASTParser.h > source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp > source/Plugins/SymbolFile/PDB/SymbolFilePDB.h > source/Symbol/ClangASTContext.cpp > >
_______________________________________________ lldb-commits mailing list [email protected] http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
