shafik added inline comments.
================
Comment at: source/Commands/CommandObjectTarget.cpp:153
+static OptionDefinition g_dependents_options[1] = {
+ {LLDB_OPT_SET_1, false, "no-dependents", 'd',
+ OptionParser::eOptionalArgument, nullptr, g_dependents_enumaration, 0,
----------------
Should "no-dependents" be "default"?
================
Comment at: source/Commands/CommandObjectTarget.cpp:181
+ const int short_option = g_dependents_options[option_idx].short_option;
+ switch (short_option) {
+ case 'd': {
----------------
Wouldn't an if/else make more sense here? I had to reread the description up
top before this made sense that `option_value` is doing the work here.
https://reviews.llvm.org/D51934
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
