[Lldb-commits] [lldb] r342280 - [IRInterpreter] Minor cleanups, add comments. NFCI.

[Davide Italiano via lldb-commits]

Author: davide
Date: Fri Sep 14 13:48:34 2018
New Revision: 342280

URL: http://llvm.org/viewvc/llvm-project?rev=342280&view=rev
Log:
[IRInterpreter] Minor cleanups, add comments. NFCI.

Modified:
    lldb/trunk/source/Expression/IRInterpreter.cpp

Modified: lldb/trunk/source/Expression/IRInterpreter.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRInterpreter.cpp?rev=342280&r1=342279&r2=342280&view=diff
==============================================================================
--- lldb/trunk/source/Expression/IRInterpreter.cpp (original)
+++ lldb/trunk/source/Expression/IRInterpreter.cpp Fri Sep 14 13:48:34 2018
@@ -601,17 +601,13 @@ bool IRInterpreter::CanInterpret(llvm::M
         Value *operand = ii->getOperand(oi);
         Type *operand_type = operand->getType();
 
-        switch (operand_type->getTypeID()) {
-        default:
-          break;
-        case Type::VectorTyID: {
+        // Vectors are currently unsupported, give up.
+        if (operand_type->getTypeID() == Type::VectorTyID)
           if (log)
             log->Printf("Unsupported operand type: %s",
                         PrintType(operand_type).c_str());
           error.SetErrorString(unsupported_operand_error);
           return false;
-        }
-        }
 
         // The IR interpreter currently doesn't know about
         // 128-bit integers. As they're not that frequent,
@@ -625,7 +621,7 @@ bool IRInterpreter::CanInterpret(llvm::M
           return false;
         }
 
-        if (Constant *constant = llvm::dyn_cast<Constant>(operand)) {
+        if (auto *constant = llvm::dyn_cast<Constant>(operand)) {
           if (!CanResolveConstant(constant)) {
             if (log)
               log->Printf("Unsupported constant: %s",


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits