> On Oct 12, 2018, at 12:52 PM, Stella Stamenova via Phabricator > <revi...@reviews.llvm.org> wrote: > > stella.stamenova added a comment. > > The bots are now failing because lexists doesn't handle NoneType correctly: > > File > "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/configuration.py", > line 191, in get_filecheck_path > if os.path.lexists(filecheck): > File "/lldb-buildbot/virenv/lib/python2.7/posixpath.py", line 152, in > lexists > os.lstat(path) > TypeError: coercing to Unicode: need string or buffer, NoneType found > > I think get_filecheck_path should check if filecheck is set first before > calling lexists: > > if filecheck and os.path.lexists(filecheck): > return filecheck
That sounds right. Would you mind committing the fix? vedant > > > Repository: > rL LLVM > > https://reviews.llvm.org/D53175 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
