stella.stamenova created this revision.
stella.stamenova added reviewers: jasonmolenda, asmith.
Herald added subscribers: lldb-commits, kbarton, nemanjai.

If the names are not unique, the tests overwrite each other's results and logs. 
This also causes failures on platforms where the files are locked for writing.

The names of the class/test pairs *have to* always be unique. The easiest way 
to achieve that is to name each class differently (usually the same as the file 
name).


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53297

Files:
  
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py


Index: 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
===================================================================
--- 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
+++ 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
@@ -5,7 +5,7 @@
 from gdbclientutils import *
 
 
-class TestThreadSelectionBug(GDBRemoteTestBase):
+class TestStopPCs(GDBRemoteTestBase):
     def test(self):
         class MyResponder(MockGDBServerResponder):
             def haltReason(self):


Index: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
===================================================================
--- packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
+++ packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
@@ -5,7 +5,7 @@
 from gdbclientutils import *
 
 
-class TestThreadSelectionBug(GDBRemoteTestBase):
+class TestStopPCs(GDBRemoteTestBase):
     def test(self):
         class MyResponder(MockGDBServerResponder):
             def haltReason(self):
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] [PATCH] D... Stella Stamenova via Phabricator via lldb-commits

Reply via email to