zturner added a comment.

I envision `FileSpec` as being more of a `PathSpec`.  It should be able 
manipulate paths as strings and nothing more.  There is indeed some logic that 
still remains that resolves paths, but it manages to do this using LLVM's file 
system APIs and the only reason it's still there is because it was baked in and 
a bit hard to remove.

One idea for removing it would be to have `FileSpec FileSystem::Resolve(const 
FileSpec &)`.  Then instead of saying `FileSpec foo(path, /*resolve = */ 
true);`, they could say `FileSpec foo = FileSystem::Resolve(FileSpec(path));` 
or something.


https://reviews.llvm.org/D53532



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to