clayborg added a comment.
Just a few nits, but _very_ close.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:65
typedef std::vector<DWARFUnitSP> CompileUnitColl;
+ typedef std::unordered_map<uint64_t, uint32_t> TypeSignatureMap;
----------------
Use llvm::DenseMap here?
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:797
+DWARFCompileUnit *DWARFUnit::GetAsCompileUnit() {
+ if (GetUnitDIEOnly().Tag() == DW_TAG_compile_unit)
+ return static_cast<DWARFCompileUnit *>(this);
----------------
Should this just be "if (GetUnitDIEOnly().Tag() != DW_TAG_type_unit)"? Partial
units and many others can be top level DIEs.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51578
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
