For dotest style tests, the debug format to test is chosen by the test driver. All the tests should run with any format, but sometimes there are bugs in one reader or another (or in one version of DWARF or another) so you can skip or xfail a test based on format. Sounds like this test should be skipped when the debug format is PDB, since it seems like either the PDB format doesn't express a way to find the actual size of the vla (or the current PDB reader doesn't process those records).
Jim > On Nov 7, 2018, at 2:00 PM, Stella Stamenova via Phabricator > <revi...@reviews.llvm.org> wrote: > > stella.stamenova added a comment. > > In https://reviews.llvm.org/D53530#1290680, @aprantl wrote: > >> In https://reviews.llvm.org/D53530#1290664, @stella.stamenova wrote: >> >>> TestVla fails on Windows: >>> http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio >>> >>> AssertionError: False is not True : 'frame var vla' returns expected >>> result, got '(int []) vla = {}' >>> >>> >>> I will have time to look in more detail later this week, but if you have >>> any ideas in the mean time, that would be great. >> >> >> Is your bot using DWARF or CodeView as a debug info format? Because this >> test definitely requires DWARF. > > > I was under the impression that each test can control how to build the > necessary payloads. Is that not the case? > > > Repository: > rL LLVM > > https://reviews.llvm.org/D53530 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
