I took a brief look and I have a question about the usage of clang (rather than clang-cl).
In general I would agree that we have an exact path of clang (or gcc) that we are trying to use and they’re specified by using %cc and %cxx in the test files, but there are a number of test files that simply use clang e.g.: SymbolFile\DWARF\find-variable-dwo.cpp:3:// RUN: clang %s -g -gsplit-dwarf -c -emit-llvm -o - --target=x86_64-pc-linux -DONE In this case, are we not going to pick up whatever clang happens to be in the path instead of one that was explicitly specified? Is this intentional? Thanks, -Stella From: Zachary Turner <ztur...@google.com> Sent: Tuesday, November 13, 2018 2:46 PM To: reviews+d54009+public+0e164460da8f1...@reviews.llvm.org Cc: Stella Stamenova <sti...@microsoft.com>; pa...@labath.sk; chris.biene...@me.com; dccitali...@gmail.com; aleksandr.ura...@jetbrains.com; jdevliegh...@apple.com; abidh....@gmail.com; teempe...@gmail.com; ki.s...@gmail.com; mgo...@gentoo.org; d...@su-root.co.uk; jfbast...@apple.com; lldb-commits@lists.llvm.org; l...@inglorion.net Subject: Re: [PATCH] D54009: Refactor LLDB lit configuration files I think it must be related to setting up the environment in which to run clang. In all other projects we call llvm_config.use_clang() which is in llvm/utils/lit/lit/llvm/config.py, but because here we have an exact path of a clang we are trying to use, we skip this function in LLDB's lit configuration files. But there is also a lot of other logic in that function, so perhaps it's some of that logic that's necessary. On Mon, Nov 12, 2018 at 9:02 AM Aleksandr Urakov via Phabricator <revi...@reviews.llvm.org<mailto:revi...@reviews.llvm.org>> wrote: aleksandr.urakov added a comment. But all compiles without errors if I run this manually: clang-cl -m32 /Z7 /c /GS- C:\Work\llvm\tools\lldb\lit\SymbolFile\PDB/Inputs/SimpleTypesTest.cpp /o C:\Work\llvm\build_x86\tools\lldb\lit\SymbolFile\PDB\Output/SimpleTypesTest.cpp.enums.obj Repository: rLLDB LLDB https://reviews.llvm.org/D54009<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD54009&data=02%7C01%7CSTILIS%40microsoft.com%7C4d34b00c93e54eec4ee808d649b9bf0e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636777459461497267&sdata=XicxM31dp6rkqlAIJcT9Aa9TjZv0pfyBWwUbp%2FKsIYM%3D&reserved=0>
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
