labath added a comment.
I haven't been following the reproducer work in detail, but this seems
reasonable to me. Thanks for incorporating my drive-by suggestions.
================
Comment at: include/lldb/Utility/Reproducer.h:104
+ template <typename T> T *Create() {
+ std::unique_ptr<ProviderBase> provider(new T(m_root));
+ return static_cast<T *>(Register(std::move(provider)));
----------------
You should still be able to use make_unique here.
================
Comment at: include/lldb/Utility/Reproducer.h:134
- std::vector<std::unique_ptr<Provider>> m_providers;
+ /// List of providers indexed by their name for easy access.
+ llvm::DenseMap<const void *, std::unique_ptr<ProviderBase>> m_providers;
----------------
Out of date comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54616/new/
https://reviews.llvm.org/D54616
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
