lemo added a comment.
I noticed a small problem, this change breaks "lldb -c <corefile>". The inline
comment explains the root cause.
Thanks
================
Comment at: lldb/trunk/tools/driver/Driver.cpp:310
+ if (args.hasArg(OPT_core)) {
+ SBFileSpec file(optarg);
+ if (file.Exists()) {
----------------
there's a small bug in here: optarg is the global definition, I assume the
intention was to use the getValue() instead. as is, it breaks "lldb -c
<corefile>"
it would be nice to get rid the global optarg as well since it masks these kind
of mistakes.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54692/new/
https://reviews.llvm.org/D54692
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
