labath added a comment.

In D54914#1311492 <https://reviews.llvm.org/D54914#1311492>, @zturner wrote:

> I think it would be good to use the way dotest works as a starting point.  
> You can specify --arch, and then you can run the test on multiple arches this 
> way by running dotest several times in succession, each with different arch 
> flags.
>
> I think a --triple option could be useful in limited scenarios, but I think 
> that most of the use cases will not need it.  Most tests will probably want 
> to specify nothing at all and let the lit configuration pass the correct 
> information through.  Actually, I think this is the same with the --arch flag 
> though.  Because as soon as you specify something, then it limits the ability 
> of the test to run over and over with different parameters.


I am not sure about their relative ratio, but yes, I agree that we have (or 
want to have) two kinds of tests. One would specify the target and the other 
would not.

> Perhaps we could support *both* a --triple and a --arch flag.  Maybe we can 
> make the script error if they're both specified.  This would give each test 
> the capability to be written in the simplest way possible.

Yes, I suppose that would work


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54914/new/

https://reviews.llvm.org/D54914



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to