sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
================
Comment at: CMakeLists.txt:134
--srcRoot=${LLDB_SOURCE_DIR}
- --targetDir=${LLDB_PYTHON_TARGET_DIR}
- --cfgBldDir=${LLDB_PYTHON_TARGET_DIR}
+ --targetDir=$<TARGET_PROPERTY:liblldb,LIBRARY_OUTPUT_DIRECTORY>
+ --cfgBldDir=$<TARGET_PROPERTY:swig_wrapper,BINARY_DIR>
----------------
sgraenitz wrote:
> JDevlieghere wrote:
> > stella.stamenova wrote:
> > > I have a vague recollection that using TARGET_PROPERTY didn't work for
> > > some changes I was working on a few months ago, but I don't remember the
> > > details. It would be good to make sure that this works on mac, linux and
> > > windows all before you commit.
> > IIRC and if we’re talking about the same thing, the generator expressions
> > didn’t work because we were using them in a configured file (the
> > lldb-dotest wrapper). Anyway, still worth double checking here.
> Yes, whenever we use a generator expression, there must be a processing step
> at generation time that expands the expression. Debugging can become hairy,
> because `message($<GENEX:target>)` doesn't have such a step (but the
> `COMMAND` in `add_custom_target` has one).
>
> Anyway, I had another look and indeed the genex's are not necessary here. I
> would really like to keep the info in the target properties though, because
> that's where CMake needs it and we can avoid duplicating it to global
> variables.
>
> I will double check that this works on the common platforms before I commit
> all my related changes.
BTW removed generator expressions here and now use `get_target_property` to
fetch property values at configuration time.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55332/new/
https://reviews.llvm.org/D55332
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
