tatyana-krasnukha marked an inline comment as done.
tatyana-krasnukha added inline comments.


================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707
+        else
+          // The register info is incorrect, just clear it.
+          m_register_info.Clear();
----------------
clayborg wrote:
> Is this a GDB server that you can modify? Or is the code fixed? Seems weird 
> to ask for registers, and get something back that doesn't work, and then have 
> to fix it up. Why even tell us the registers then?
None of 3 gdb-servers we use provides us with "dwarf" field (including Ashling 
gdb-server and OpenOCD). It's not their business to be aware of DWARF. 

I'm going to hardcode necessary registers in SysVABI_arc, then 
AugmentRegisterInfoViaABI will solve the problem.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55718/new/

https://reviews.llvm.org/D55718



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to