zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land.
This is really cool, thanks for doing this! ================ Comment at: source/Expression/DWARFExpression.cpp:3253 - return false; + return true; } ---------------- Why do we change the return value here? ================ Comment at: source/Plugins/SymbolFile/NativePDB/CodeViewRegisterMapping.h:16 + +uint32_t GetLLDBRegisterNumber(llvm::Triple::ArchType arch_type, + llvm::codeview::RegisterId register_id); ---------------- Can you put this function in the `lldb_private::npdb` namespace? ================ Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.h:20 + +bool TranslateFPOProgramToDWARFExpression(llvm::StringRef program, + llvm::StringRef register_name, ---------------- Can you put this function in the `lldb_private::npdb` namespace? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
