aprantl added inline comments.

================
Comment at: 
lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/TestStdModuleWithConflicts.py:35
+
+        self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
+
----------------
teemperor wrote:
> aprantl wrote:
> > what's that for?
> I think that's how we set our executable as the target? It's frankly 
> cargo-culted setup code that we use in a few hundred other tests.
lldbutil.run_break_set_by_file_and_line should be all you need. It has a.out as 
a default argument. So I don't think you need this line or the one defining 
exe, or the dictionary=... argument to build().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58125/new/

https://reviews.llvm.org/D58125



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to