labath added a comment. I think this is fine, except for the things I pointed out inline. As for `SafelyCloseFileDescriptor` (wow) thing, I think we should use that, given that it's already there. I suggest making a separate patch for that.
CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
