jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good. Removing that printf is good. Could you also remove the
printf("mach_header:...") in the same function?
It would be nice if include/lldb/Target/Process.h had the decl for
ReadMemoryFromInferior right after ReadMemory(), and a comment that
ReadMemoryFromInferior does not go through the memory cache (and most callers
should go through ReadMemory()) so people know what the difference is.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59896/new/
https://reviews.llvm.org/D59896
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
