davide added a comment.

While the intentions of exposing this are good, the implementation leaks too 
many details. In fact, there shouldn't be anything outside of ScriptInterpreter 
guarded by `LLDB_DISABLE_PYTHON`.
You might want also to realize that having `ePathTypePythonDir` goes against 
the whole notion of a generic pluggable interpreter. 
Imagine tomorrow somebody wants to implement support for another language, what 
would this call return for it?

If we really want to keep supporting this, maybe the ScriptInterpreter should 
have a base method that we can override? Still sounds a little bizarre to me 
because it's really hard to generalize the notion of `PythonDir` for any other 
language whatsoever.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61090/new/

https://reviews.llvm.org/D61090



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to