labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/lit/Register/Inputs/x86-64-read.cpp:8
+int main() {
+  uint64_t r8 = 0x0102030405060708;
+  uint64_t r9 = 0x1112131415161718;
----------------
what do you think about including r0-r7 too? They're of different sizes on x86 
vs x86_64, so I don't think we'll be able to have a single test which would 
work on both arches.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61072/new/

https://reviews.llvm.org/D61072



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to