jingham added a comment. Looks good to me too. The fact that you were mostly eliminating redirections from CommandInterpreter -> Debugger is good evidence this was wrongly structured initially.
I'm a little curious that we do: m_debugger.GetCommandInterpreter().GetPythonCommandsFromIOHandler to read "break command add -s python" command text. Seems like the script interpreter IO handler should do this otherwise the Command Interpreter has to know the right way to do input for every script interpreter. But I think that's a change for another patch. This one seems pure goodness. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61172/new/ https://reviews.llvm.org/D61172 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
