[Lldb-commits] [PATCH] D61469: [Alias] Add 're' alias for register

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: jingham.
Herald added a project: LLDB.

This patch makes `re` an alias for `register`. Currently `re<TAB>` gives you 
the choice between `register` and `reproducer`. Given that you use `register` a 
lot more often, `register` should win for the common substring.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D61469

Files:
  
lldb/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
  lldb/source/Interpreter/CommandInterpreter.cpp


Index: lldb/source/Interpreter/CommandInterpreter.cpp
===================================================================
--- lldb/source/Interpreter/CommandInterpreter.cpp
+++ lldb/source/Interpreter/CommandInterpreter.cpp
@@ -429,6 +429,11 @@
     AddAlias("var", cmd_obj_sp);
     AddAlias("vo", cmd_obj_sp, "--object-description");
   }
+
+  cmd_obj_sp = GetCommandSPExact("register", false);
+  if (cmd_obj_sp) {
+    AddAlias("re", cmd_obj_sp);
+  }
 }
 
 void CommandInterpreter::Clear() {
Index: 
lldb/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
===================================================================
--- 
lldb/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
+++ 
lldb/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
@@ -187,7 +187,8 @@
         elif not value.IsValid():
             return  # If register doesn't exist, skip this test
 
-        self.runCmd("register write " + register + " \'" + new_value + "\'")
+        # Also test the 're' alias.
+        self.runCmd("re write " + register + " \'" + new_value + "\'")
         self.expect(
             "register read " +
             register,



Index: lldb/source/Interpreter/CommandInterpreter.cpp
===================================================================
--- lldb/source/Interpreter/CommandInterpreter.cpp
+++ lldb/source/Interpreter/CommandInterpreter.cpp
@@ -429,6 +429,11 @@
     AddAlias("var", cmd_obj_sp);
     AddAlias("vo", cmd_obj_sp, "--object-description");
   }
+
+  cmd_obj_sp = GetCommandSPExact("register", false);
+  if (cmd_obj_sp) {
+    AddAlias("re", cmd_obj_sp);
+  }
 }
 
 void CommandInterpreter::Clear() {
Index: lldb/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
+++ lldb/packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
@@ -187,7 +187,8 @@
         elif not value.IsValid():
             return  # If register doesn't exist, skip this test
 
-        self.runCmd("register write " + register + " \'" + new_value + "\'")
+        # Also test the 're' alias.
+        self.runCmd("re write " + register + " \'" + new_value + "\'")
         self.expect(
             "register read " +
             register,

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits