clayborg added inline comments.
================ Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:378 + // Unwind rules are of the form + // register1: expression1 register2: expression2 ... + // We assume none of the tokens in expression<n> end with a colon. ---------------- This format seems a bit challenging to parse ================ Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:418 + if (name == ".ra") + return resolver.ResolveNumber(eRegisterKindGeneric, LLDB_REGNUM_GENERIC_PC); + return ResolveRegister(resolver, name); ---------------- LLDB_REGNUM_GENERIC_RA? Do we want the PC here or do we want the link register? ================ Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:491-492 + llvm::Optional<StackCFIRecord> init_record = StackCFIRecord::parse(*It); + assert(init_record.hasValue()); + assert(init_record->Size.hasValue()); + ---------------- will this code be ok if the assertions are compiled out? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61733/new/ https://reviews.llvm.org/D61733 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
