JDevlieghere added inline comments.
================
Comment at: include/lldb/Target/Language.h:197
+ virtual void
+ GetVariantMethodNames(ConstString method_name,
+ std::vector<ConstString> &variant_names) const {
----------------
GetMethodNameVariants?
================
Comment at: source/Breakpoint/BreakpointResolverName.cpp:237
+
+ Language *lang = Language::FindPlugin(m_language);
+ if (!lang) {
----------------
You could write this as
```
if (Language *lang = Language::FindPlugin(m_language)) {
add_variant_funcs(lang);
} else {
// Most likely m_language is eLanguageTypeUnknown. We check each language
for
// possible variants or more qualified names and create lookups for those as
// well.
Language::ForEach(add_variant_funcs);
}
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61746/new/
https://reviews.llvm.org/D61746
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
