stella.stamenova requested changes to this revision.
stella.stamenova added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/lit/Breakpoint/case-sensitive.test:1
-# REQUIRES: nowindows
+# UNSUPPORTED: windows
#
----------------
This should be system-windows. See config.py in llvm. By using system-windows,
the test would be consistent with other platforms. Incidentally, I am just
about to fix this as well as the test in LLVM that you changed to use windows -
it should also use system-windows.
================
Comment at: lldb/lit/lit.cfg.py:101
+# Allow distinguishing Windows host from others.
+if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
+ config.available_features.add('windows')
----------------
This really should live in config.py in llvm so that it can be used across all
projects. And it should be system-windows for consistency with other platforms.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61752/new/
https://reviews.llvm.org/D61752
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
