labath added a comment. In D62948#1532549 <https://reviews.llvm.org/D62948#1532549>, @mgorny wrote:
> In D62948#1532531 <https://reviews.llvm.org/D62948#1532531>, @labath wrote: > > > Update other tests too. I also forgot to mention that this enables the > > 32-bit > > tests to run on 64-bit platforms too by explicitly compiling for 32-bit > > (-m32). > > > I'm not sure if this is a good idea. I was thinking about it originally but I > suspected it might cause failures on non-multilib systems. Yeah, you're right. I'll revert that part. I did it mainly so I could test my changes there, though it would be nice to have these test run generally too, as these days I expect most people who debug 32-bit apps will be using a 64-bit debugger. I guess we'll one day need a "can-run-32-bit-code" feature, though I'm not sure how to go about implementing that. in cmake? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62948/new/ https://reviews.llvm.org/D62948 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
