jankratochvil marked 4 inline comments as done. jankratochvil added a comment.
In D63540#1549977 <https://reviews.llvm.org/D63540#1549977>, @labath wrote: > Why was it necessary to change the iteration order here? No, it was an accidental leftover. Thanks for the review. ================ Comment at: lldb/lit/SymbolFile/sizeless-symbol.test:1 +# RUN: %clang %S/Inputs/sizeless-symbol.s -c -o %t.o +# RUN: %lldb %t.o -s %s -o quit | FileCheck %s ---------------- labath wrote: > Are you sure this will work whatever the host triple happens to be ? (you can > try it out by manually forcing a couple of random targets with the `-target` > argument). I have a feeling the `.type`, `.size`, etc. directives are a > feature of elf-targetting assemblers. If that doesn't work you can always > force a specific triple with the `-target` command. Yes, you are right. ================ Comment at: lldb/lit/SymbolFile/sizeless-symbol.test:4 + +image lookup --address 1 +# CHECK: Summary: sizeless-symbol.test.tmp.o`sizeful ---------------- labath wrote: > As you're fixing this bug by changing the way symbol size is computed, it > would be nice to also put (and check it's output) a "image dump symtab" > command here. That would also make it clear what are the assumptions the > following "lookup" commands are operating under. I only hope the `image dump symtab` output ordering is stable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
