labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine to me.
Instead of just throwing the error away when the thread creation fails (and
there's no way to pass it up the stack), I'd consider logging the error instead.
================
Comment at: lldb/source/Target/Process.cpp:3601
+
if (m_private_state_thread.IsJoinable()) {
ResumePrivateStateThread();
----------------
I would assume this should always be true for a successfully created thread.
Delete the check or change to an assert maybe?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64163/new/
https://reviews.llvm.org/D64163
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
