Author: jdevlieghere Date: Mon Jul 8 15:45:59 2019 New Revision: 365403 URL: http://llvm.org/viewvc/llvm-project?rev=365403&view=rev Log: [ThreadLauncher] Use mapWindowsError and LLDB_INVALID_HOST_THREAD
Address post-commit feedback from Pavel and Jim. Modified: lldb/trunk/source/Host/common/ThreadLauncher.cpp Modified: lldb/trunk/source/Host/common/ThreadLauncher.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/ThreadLauncher.cpp?rev=365403&r1=365402&r2=365403&view=diff ============================================================================== --- lldb/trunk/source/Host/common/ThreadLauncher.cpp (original) +++ lldb/trunk/source/Host/common/ThreadLauncher.cpp Mon Jul 8 15:45:59 2019 @@ -31,10 +31,8 @@ llvm::Expected<HostThread> ThreadLaunche thread = (lldb::thread_t)::_beginthreadex( 0, (unsigned)min_stack_byte_size, HostNativeThread::ThreadCreateTrampoline, info_ptr, 0, NULL); - if (thread == (lldb::thread_t)(-1L)) { - DWORD err = GetLastError(); - return llvm::errorCodeToError(std::error_code(err, std::system_category())); - } + if (thread == LLDB_INVALID_HOST_THREAD) + return llvm::errorCodeToError(llvm::mapWindowsError(GetLastError())); #else // ASAN instrumentation adds a lot of bookkeeping overhead on stack frames. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits