teemperor marked an inline comment as done. teemperor added inline comments.
================ Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:223 + // Returns true if this is the last token we get from the lexer. + exit = lex.LexFromRawLexer(token); + ---------------- JDevlieghere wrote: > Can we write this as `while(!lex.LexFromRawLexer(token))`? LexFromRawLexer seems to return `true` when the current result is the last token (but still a valid token), so I think no :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64194/new/ https://reviews.llvm.org/D64194 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits