asmith marked 11 inline comments as done.
asmith added inline comments.

================
Comment at: 
lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:95
+
+    // Resume the debug loop.
+    ExceptionRecordSP active_exception =
----------------
amccarth wrote:
> This code appears to be based on `ProcessWindows::DoResume`, which has a 
> pending patch to fix a race condition by moving the checking of the exception 
> record to later in the function.  I assume this will need the same fix.  See 
> https://reviews.llvm.org/D62183 for details.
Thanks for the heads up


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63165/new/

https://reviews.llvm.org/D63165



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to