clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We can't change functionality in our API. Fine to add something to SBDebugger,
but we can't just disable a call that used to work in SBHostOS.
================
Comment at: lldb/source/API/SBHostOS.cpp:63
case ePathTypePythonDir:
-#ifndef LLDB_DISABLE_PYTHON
- fspec = ScriptInterpreterPython::GetPythonDir();
-#endif
+ // Deprecated. Use SBCommandInpterpreter::GetScriptModuleDirectory instead.
break;
----------------
So now we don't return anything here? That is bad. this can break older scripts
and violates our API. Deprecation is not the same as disabling the
functionality that once worked.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61090/new/
https://reviews.llvm.org/D61090
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
