labath added a comment.

Though I am not very familiar VFS, this seems like the most intuitive solution 
out of everything that we had so far. But... shouldn't you also check that the 
directory you're `chdir`-ing into "exists" before you actually change the cwd? 
Also, the chdir operation should probably follow the usual semantics of a 
non-absolute chdir path being treated as relative to the previous cwd. And 
lastly :), what is the initial cwd value? Since previously the class shared the 
cwd with the underlying filesystem, one option might be to fetch the initial 
cwd from there (though I don't know if that is actually desired). Another 
option might be to just pick the first directory in the yaml file or 
something...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65677/new/

https://reviews.llvm.org/D65677



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to