aprantl marked an inline comment as done. aprantl added inline comments.
================ Comment at: lldb/include/lldb/Utility/Scalar.h:107 + /// Return the most efficient Scalar::Type for the requested size. + static Type GetBestType(size_t bit_size, bool sign); + ---------------- vsk wrote: > JDevlieghere wrote: > > How about `GetTypeForBitSize`? > nit: bool signed ? that name conflicts with the actual type `signed`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67369/new/ https://reviews.llvm.org/D67369 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
