JDevlieghere added a comment. +1 on a test case. Other than that this seems like a good improvement to the way we filter stop reasons.
================ Comment at: source/Interpreter/CommandInterpreter.cpp:2164 + StopReason reason = stop_info->GetStopReason(); + if (eStopReasonException == reason || eStopReasonInstrumentation == reason) + return true; ---------------- I'm curious why you swapped the two operands. Is there a benefit in `eStopReasonException == reason` compared to `reason == eStopReasonException`? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67776/new/ https://reviews.llvm.org/D67776 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
