labath added reviewers: amccarth, ted. labath added a comment. This is looking very good to me. Adding some windows folks to help with trying this out on that platform.
================ Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 + module_path = options.python_relative_path + if module_path is None: + from distutils.sysconfig import get_python_lib ---------------- hhb wrote: > hhb wrote: > > Just bail out in this situation? So that the error can be more obvious. > > E.g. someone changed cmake file but didn't know to update here. > finishSwigPythonLLDB.py also need to be updated similar to what you did here. > Specially get_framework_python_dir() and make_symlink(). +1 for bailing out here. ================ Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:326 llvm::sys::path::remove_filename(path, style); llvm::sys::path::append(path, style, "lib", "site-packages"); ---------------- hhb wrote: > Also update the path for windows using LLDB_PYTHON_RELATIVE_LIBDIR? Possibly, though i think this could also be done in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67890/new/ https://reviews.llvm.org/D67890 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
