aprantl added inline comments.
================ Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3077 + ParseType(sc, die, &type_is_new).get(); + printf( "pubname: %s is_type = %d\n", die.GetPubname(), true); + break; ---------------- You also probably don't want to actually print anything here? ================ Comment at: tools/lldb-test/lldb-test.cpp:555 + size_t ntypes = symfile->GetTypes(nullptr, eTypeClassAny, type_list); + printf( "Type list size: %zu\n", ntypes); + ---------------- The rest of the file seems to use `llvm::outs()` instead of printf. ================ Comment at: tools/lldb-test/lldb-test.cpp:564 + record_decl->dump(); + else if( clang::TagDecl *tag_decl = + clang_ast_ctx->GetAsTagDecl(type->GetFullCompilerType()) ) ---------------- clang-format ================ Comment at: tools/lldb-test/lldb-test.cpp:570 + typedef_decl->dump(); + else if( clang::EnumDecl *enum_decl = clang_ast_ctx->GetAsEnumDecl(type->GetFullCompilerType()) ) + enum_decl->dump(); ---------------- switch over CompilerType->getAsClangType() ->getKind()? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67994/new/ https://reviews.llvm.org/D67994 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
