JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, labath, jingham, xiaobai.
Herald added a project: LLDB.
When all the tests run by dotest are unsupported, it still reports `RESULT:
PASSED` which we translate to success for lit. We can better report the status
as unsupported when we see that there are unsupported tests but no passing
tests. This will not affect the situation where there are failures or
unexpected passes, because those report a non-zero exit code.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D68039
Files:
lldb/lit/Suite/lldbtest.py
Index: lldb/lit/Suite/lldbtest.py
===================================================================
--- lldb/lit/Suite/lldbtest.py
+++ lldb/lit/Suite/lldbtest.py
@@ -102,6 +102,11 @@
if 'XPASS:' in out or 'XPASS:' in err:
return lit.Test.XPASS, out + err
+ has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err
+ has_passing_tests = 'PASS:' in out or 'PASS:' in err
+ if has_unsupported_tests and not has_passing_tests:
+ return lit.Test.UNSUPPORTED, out + err
+
passing_test_line = 'RESULT: PASSED'
if passing_test_line not in out and passing_test_line not in err:
msg = ('Unable to find %r in dotest output (exit code %d):\n\n%s%s'
Index: lldb/lit/Suite/lldbtest.py
===================================================================
--- lldb/lit/Suite/lldbtest.py
+++ lldb/lit/Suite/lldbtest.py
@@ -102,6 +102,11 @@
if 'XPASS:' in out or 'XPASS:' in err:
return lit.Test.XPASS, out + err
+ has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err
+ has_passing_tests = 'PASS:' in out or 'PASS:' in err
+ if has_unsupported_tests and not has_passing_tests:
+ return lit.Test.UNSUPPORTED, out + err
+
passing_test_line = 'RESULT: PASSED'
if passing_test_line not in out and passing_test_line not in err:
msg = ('Unable to find %r in dotest output (exit code %d):\n\n%s%s'
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
