labath added reviewers: srhines, danalbert.
labath added a comment.

I think we should take a step back first. What is the behavior we expect from 
the  "platform process list" command ? I think the current expectation is (and 
this is consistent with @clayborg's comment in 
https://reviews.llvm.org/D68048#1683238) is that it should only return the 
processes that we can attach to. The way lldb-server implements that right now 
is via comparing user ids 
https://github.com/llvm-mirror/lldb/blob/master/source/Host/linux/Host.cpp#L250.
 While these user ids don't really correspond to what android calls "users", 
they in fact do implement the "can I attach to this" semantics, as you cannot 
attach to a process with a different user id (without doing some serious run-as 
magic, which lldb-server does not know how to do right now).

So, I am not sure if there anything to change here, really... If your goal is 
to be able to see _all_ processes, even those you cannot attach to, then maybe 
we should have a separate flag/command for that. The FindProcesses API already 
supports being able to show all processes, but it does not look like there's a 
way to set that from the "platform process list" command...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68048/new/

https://reviews.llvm.org/D68048



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to