JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/lit/Host/TestCustomShell.test:5
+# RUN: SHELL=bogus %lldb %t.out -b -o 'run' 2>&1 | FileCheck %s
+# CHECK: error: shell expansion failed
----------------
JDevlieghere wrote:
> friss wrote:
> > Is there a reliable way to check that the expansion we get in lldb matches 
> > the one in the shell? For example, could we have the program dump its 
> > arguments once without lldb and match them against the lldb output?
> > 
> > I guess the zsh example that errors out in your description makes this 
> > hard?  
> You could run lldb-argdumper under lldb and compare the output to running it 
> under different shells. Do you think it's reasonable to assume that at least 
> `/bin/bash` and `/bin/zsh` are available?
Assuming we can find something that expands differently without throwing an 
error in bash and zsh.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68316/new/

https://reviews.llvm.org/D68316



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to