labath added a comment.

BTW, I've had to add (or rather, extend) a fairly ugly hack in r373573 in order 
to get the new tests running on non-darwin platforms. The reason for that is 
that the FILE* out typemap needs to get the "mode" of the object in order to 
construct the python wrapper.

My hope is that we can be improved once you're finished your work here. For 
instance by reimplementing `GetOutputFileHandle` on top of `GetOutputFile` in 
swig, as the latter will (hopefully) be able to get the mode of a file 
correctly. Does that sound reasonable, or am I totally off-track here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67793/new/

https://reviews.llvm.org/D67793



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to