labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks good. I don't think there's a reasonable way to test this, as these will fail only when running stuff under a different user, or on a system with a paranoid security module. ================ Comment at: lldb/source/Host/linux/Host.cpp:193 auto BufferOrError = getProcFile(pid, "environ"); - if (!BufferOrError) - return false; + if (!BufferOrError) { + return; ---------------- We usually don't put braces around short statements like this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits