labath added a comment.
Thanks for the review. I am fairly confident in the minidump details, as I
based this code on the existing functional implementation in lldb, which I have
also cross-referenced with the publicly available microsoft documentation.
@amccarth, @clayborg: do you want to have a look at the minidump details?
================
Comment at: lib/Object/Minidump.cpp:58
+MinidumpFile::getMemoryInfoList() const {
+ auto OptionalStream = getRawStream(StreamType::MemoryInfoList);
+ if (!OptionalStream)
----------------
jhenderson wrote:
> I probably should have picked up on this in previous reviews, but this is too
> much `auto` for my liking, as it's not obvious from the call site what
> `getRawStream` returns.
Done. I've also changed the other calls to getRawStream.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68210/new/
https://reviews.llvm.org/D68210
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
